Use BTreeSet for scopes
#123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 16, 2024
Open
…tos-hotkeys into use-btree-set-for-scopes
mondeja
reviewed
Aug 16, 2024
There was a problem hiding this comment.
I think that is not clear if would be more performant. The biggest gain here would be to define the HashSet as a HashSet<&'static str> instead of a HashSet<String> when possible (for literals), so the hashes probably are produced at compile time.
As contexts are created in a compile-time macro, it's possible to sometimes do that.
Note that BTrees are slower on lookup. Without a proper bench I don't know if this change it's worth.
+1. Going to profile! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
BTreeSetsupportsStringkeys, it's more efficient* to use a data structure without a hash step.I'd imagine we'd want to do the same with key combinations.
* untested claim